On 9/22/2017 9:59 AM, Matt Riedemann wrote:
Figuring out what is useless or not is probably not worth the effort here. We already skip long running tempest dsvm jobs in certain patches, like with docs or unit test only changes. Updating a code comment in code isn't going to catch that.

And it's perfectly valid to have useful single-line code changes (although if it's a bug there should be a test too). Or multi-line changes that are just adding comments to code.

Plus most people are probably not going to review something until CI has voted on it anyway, at least when you have the number of open reviews that some projects, like nova, has.

So I think this is a non-starter.

To summarize, this is a social issue, not a technical issue.

--

Thanks,

Matt

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to