As for downstream you can do whatever you want, but it looks like this issue should be solved in upstream. I mean if "tests" directory is located at the top level of the repo, no one will use it. Also, setuptools supports `exclude` option which should solve the issue as well.
2018-02-19 17:41 GMT+02:00 Michael Bayer <[email protected]>: > On Mon, Feb 19, 2018 at 10:39 AM, Andrey Kurilin <[email protected]> > wrote: > > Can someone explain me the reason for including "tests" module into > > packages? > > the "tests" module should not be inside packages. Downstream we have > CI running Cinder's test suite against packaged dependencies, which > fails because we don't package oslo_db.tests. > > > > > > > > 2018-02-19 17:00 GMT+02:00 Michael Bayer <[email protected]>: > >> > >> Hi list - > >> > >> Apparently Cinder was misled by my deprecations within the > >> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and > >> in https://review.openstack.org/#/c/522290/ the assumption was made > >> that these should be imported from oslo_db.tests.sqlalchemy. This > >> is an immense mistake on my part that I did not expect people to go > >> looking for the same names elsewhere in private packages and now we > >> have a serious downstream issue as these modules are not packaged, as > >> well as the possibility that the oslo_db.tests. package is now locked > >> in time and I have to add deprecations there also. > >> > >> If anyone knows of projects (or feels like helping me search) that are > >> importing *anything* from oslo_db.tests these must be reverted ASAP. > >> > >> ____________________________________________________________ > ______________ > >> OpenStack Development Mailing List (not for usage questions) > >> Unsubscribe: [email protected]?subject: > unsubscribe > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > > > > > > -- > > Best regards, > > Andrey Kurilin. > > > > ____________________________________________________________ > ______________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: [email protected]?subject: > unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Best regards, Andrey Kurilin.
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
