Hi Gilles, I just had a look at your patch, cool, thanks for the work. ok, that good to start with a limited subsets of query types indeed, you're right.
Ok, perfect for the patch to branch, I don't know why but I had the feeling that you were requesting for the branch to be merged back and not for the patch :D I just read my emails too quickly I suppose. About your code, I feel that we should extract the schemas from the base.py under neutron/api/graphql/schemas/ right now before the code became to large, that would then allows for a better granularity. Thanks. Le ven. 22 juin 2018 à 08:42, Gilles Dubreuil <[email protected]> a écrit : > > > On 22/06/18 15:57, Flint WALRUS wrote: > > Hi everyone, > > Thanks for the updates and support, that appreciated. > > @Gilles, did you already implemented all the service types? > > > We have query types for networks and subnets for now. > Before we add more we are going to focus on oslo policies so we can access > and modify those items in respect of the existing security approach. > Then we will have a solid foundation to add more types. > > > > What is left to do? You already want to merge the feature branch with > master? > > > The feature branch graphql is the Proof of Concept and won't be merged to > master until we have it full ready to share/demonstrate it to others. > So we're pushing patches against that branch. The initial one to be > hopefully merged soon. > > > > @tristan I’d like to work on the feature branch but I’ll wait for gilles > answers as I don’t want to mess up having pieces of code everywhere. > > Thanks! > Le ven. 22 juin 2018 à 06:44, Gilles Dubreuil <[email protected]> a > écrit : > >> >> On 22/06/18 09:21, Tristan Cacqueray wrote: >> >> Hi Flint, >> >> On June 21, 2018 5:32 pm, Flint WALRUS wrote: >> >> Hi everyone, sorry for the late answer but I’m currently trapped into a >> cluster issue with cinder-volume that doesn’t give me that much time. >> >> That being said, I’ll have some times to work on this feature during the >> summer (July/August) and so do some coding once I’ll have catched up with >> your work. >> >> That's great to hear! The next step is to understand how to deal with >> oslo policy and control objects access/modification. >> >> Did you created a specific tree or did you created a new graphql folder >> within the neutron/neutron/api/ path regarding the schemas etc? >> >> >> There is a feature/graphql branch were an initial patch[1] adds a new >> neutron/api/graphql directory as well as a new test_graphql.py >> functional tests. >> The api-paste is also updated to expose the '/graphql' http endpoint. >> >> Not sure if we want to keep on updating that change, or propose further >> code as new change on top of this skeleton? >> >> >> Makes sense to merge it, I think we have the base we needed to get going. >> I'll make it green so we can get merge it. >> >> >> Regards, >> -Tristan >> >> >> Le sam. 16 juin 2018 à 08:42, Tristan Cacqueray <[email protected]> >> <[email protected]> a >> écrit : >> >> On June 15, 2018 10:42 pm, Gilles Dubreuil wrote: >> > Hello, >> > >> > This initial patch [1] allows to retrieve networks, subnets. >> > >> > This is very easy, thanks to the graphene-sqlalchemy helper. >> > >> > The edges, nodes layer might be confusing at first meanwhile they make >> > the Schema Relay-compliant in order to offer re-fetching, pagination >> > features out of the box. >> > >> > The next priority is to set the unit test in order to implement >> mutations. >> > >> > Could someone help provide a base in order to respect Neutron test >> > requirements? >> > >> > >> > [1] [abandoned] >> >> Actually, the correct review (proposed on the feature/graphql branch) >> is: >> >> [1] https://review.openstack.org/575898 >> >> > >> > Thanks, >> > Gilles >> > >> > >> __________________________________________________________________________ >> >> > OpenStack Development Mailing List (not for usage questions) >> > Unsubscribe: >> [email protected]?subject:unsubscribe >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > >> __________________________________________________________________________ >> >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> [email protected]?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> __________________________________________________________________________ >> >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> [email protected]?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> [email protected]?subject:unsubscribehttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> -- >> Gilles Dubreuil >> Senior Software Engineer - Red Hat - Openstack DFG Integration >> Email: [email protected] >> GitHub/IRC: gildub >> Mobile: +61 400 894 219 <+61%20400%20894%20219> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> [email protected]?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > -- > Gilles Dubreuil > Senior Software Engineer - Red Hat - Openstack DFG Integration > Email: [email protected] > GitHub/IRC: gildub > Mobile: +61 400 894 219 <+61%20400%20894%20219> > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
