The actual problem is that the manifest isn't idempotent anymore: http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_705516 So something in your patch is breaking the Keystone_domain provider and makes it non idempotent.
On Tue, Jul 3, 2018 at 7:30 PM Lars Kellogg-Stedman <l...@redhat.com> wrote: > I need another set of eyes. > > I have a review that keeps failing here: > > > http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_696966 > > It's looking for the regular expression: > > /Puppet::Type::Keystone_tenant::ProviderOpenstack: Support for a > resource without the domain.*using 'Default'.*default domain id is '/ > > The output shown in the failure message contains: > > [1;33mWarning: Puppet::Type::Keystone_tenant::ProviderOpenstack: > Support for a resource without the domain set is deprecated in > Liberty cycle. It will be dropped in the M-cycle. Currently using > 'Default' as default domain name while the default domain id is > '7ddf1dfa7fac46679ba7ae2245bece2f'.[0m > > The regular expression matches the text! The failing test is here: > > > https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/default_domain_spec.rb#L59 > > I've been staring at this for a while and I'm not sure what's going > on. > > -- > Lars Kellogg-Stedman <l...@redhat.com> | larsks @ {irc,twitter,github} > http://blog.oddbit.com/ | > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Emilien Macchi
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
