Hi Cinder and Nova folks, Working on some tests for our drivers, I stumbled upon this tempest test 'force_detach_volume' that is calling Cinder API passing a 'None' connector. At the time this was added several CIs went down, and people started discussing whether this (accepting/sending a None connector) would be the proper behavior for what is expected to a driver to do[1]. So, some of CIs started just skipping that test[2][3][4] and others implemented fixes that made the driver to disconnected the volume from all hosts if a None connector was received[5][6][7].
While implementing this fix seems to be straightforward, I feel that just removing the volume from all hosts is not the correct thing to do mainly considering that we can have multi-attach. So, my questions are: What is the best way to fix this problem? Should Cinder API continue to accept detachments with None connectors? If, so, what would be the effects on other Nova attachments for the same volume? Is there any side effect if the volume is not multi-attached? Additionally to this thread here, I should bring this topic to tomorrow's Cinder's meeting, so please join if you have something to share. Erlon ___________________ [1] https://bugs.launchpad.net/cinder/+bug/1686278 [2] https://openstack-ci-logs.aws.infinidat.com/14/578114/2/check/dsvm-tempest-infinibox-fc/14fa930/console.html [3] http://54.209.116.144/14/578114/2/check/kaminario-dsvm-tempest-full-iscsi/ce750c8/console.html [4] http://logs.openstack.netapp.com/logs/14/578114/2/upstream-check/cinder-cDOT-iSCSI/8e2c549/console.html#_2018-07-16_20_06_16_937286 [5] https://review.openstack.org/#/c/551832/1/cinder/volume/drivers/dell_emc/vnx/adapter.py [6] https://review.openstack.org/#/c/550324/2/cinder/volume/drivers/hpe/hpe_3par_common.py [7] https://review.openstack.org/#/c/536778/2/cinder/volume/drivers/infinidat.py
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
