Hi Alexei: Thanks for your information. IMO, if you remove them, the file tools/nova.bash_completion should be removed too, right?
If so, I'm willing to participate with you to do this. 2014/1/15 Alexei Kornienko <[email protected]> > Hello Lingxian, > > Actually I'm planning to remove both of them. > > I'm working on integration of argcomplete ( > https://github.com/kislyuk/argcomplete) library to openstack clients: > https://review.openstack.org/#/c/65863/ > https://review.openstack.org/#/c/65864/ > https://review.openstack.org/#/c/65865/ > > With such approach we'll remove both commands and simplify competition > implementation. > > Regards, > Alexei Kornienko > > > On 01/15/2014 08:51 AM, Lingxian Kong wrote: > > Now, novaclient supports 'bash-completion' and 'bash_completion' > commands at the same time, after I checked the commit history, I found that > the '_add_bash_completion_subparser' function and 'do_bash_completion' > function were added in at 2011/12/16 by Rick Harris, with the Change-Id: > If882f7a822ef6b1e58666b3af6f7166ab0a230fe. > > then, there are two parsers with the same usage, but with different > commands, one is 'bash-completion', and the other is 'bash_completion', I > think it's not what the author supposed to do. > > and by the way, there are two things should be noticed: > 1. there is only unittest for 'bash-completion'. > 2. the command 'bash_completion' can't be found with 'nova help', which > means it's not seen by users. > > so, I purpose removing 'bash_completion'. Thoughts? > > -- > *---------------------------------------* > *Lingxian Kong* > Huawei Technologies Co.,LTD. > IT Product Line CloudOS PDU > China, Xi'an > Mobile: +86-18602962792 > Email: [email protected]; [email protected] > > > _______________________________________________ > OpenStack-dev mailing > [email protected]http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > _______________________________________________ > OpenStack-dev mailing list > [email protected] > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- *---------------------------------------* *Lingxian Kong* Huawei Technologies Co.,LTD. IT Product Line CloudOS PDU China, Xi'an Mobile: +86-18602962792 Email: [email protected]; [email protected]
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
