Hi David, Just had a short talk with markwash. Based on the new design of v2, we don't need 'killed' status anymore. Since when user is uploading a modification to an image and the upload fails, it should just go back to what it was, it shouldn't be deactivated.
Thanks & Best regards,
Fei Long Wang (王飞龙)
---------------------------------------------------------------------
Tech Lead of Nitrogen (SME team)
Cloud Solutions and OpenStack Development
Tel: 8610-82450513 | T/L: 905-0513
Email: flw...@cn.ibm.com
China Systems & Technology Laboratory in Beijing
---------------------------------------------------------------------
From: David Koo <kpublicm...@gmail.com>
To: OpenStack Development Mailing List
<openstack-dev@lists.openstack.org>,
Date: 01/26/2014 09:13 PM
Subject: Re: [openstack-dev] Fw: [Glance] Is the 'killed' state ever set
in v2?
Hi Fei,
Thanks for the confirmation.
> I think you're right. The 'killed' status should be set in method upload
()
> if there is an upload failure, see
>
https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244
I think you meant:
https://github.com/openstack/glance/blob/master/glance/api/v1/upload_utils.py#L244
(the safe_kill() call) right?
--
Koo
> ------------------ Original ------------------
> From: "David Koo"<kpublicm...@gmail.com>;
> Date: Jan 26, 2014
> To: "OpenStack Development Mailing
> List"<openstack-dev@lists.openstack.org>;
> Subject: [openstack-dev] [Glance] Is the 'killed' state ever set in v2?
>
> Hi All,
>
> While trying to work on a bug I was trying to simulate some image
> download failures and found that apparently the 'killed' state is never
> set using v2 APIs.
>
> If I understand correctly, a file upload goes to
> api.v2.image_data.ImageDataController.upload and goes all the way to
> store.ImageProxy.set_data which proceeds to write to the backend store.
>
> If the backend store raises an exception it is simply propagated all the
> way up. The notifier re-encodes the exceptions (which is the bug I was
> looking at) but doesn't do anything about the image status.
>
> Nowhere does the image status seem to get set to 'killed'.
>
> Before I log a bug I just wanted to confirm with everybody whether or
> not I've missed out on something.
>
> Thanks.
>
> --
> Koo
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
<<inline: graycol.gif>>
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
