@flwang, np at all. We can put the input in bug report as a comment or here anyway, as far as it can let us/me know the gains/advantages on this "fix".
I'd like to know whether there is a backward-compatibility issue, but seems it's not a big deal? To keep the image property be case-sensitive is make sense, at last it is better if we keep same property name as client provided. zhiyan On Mon, Jan 27, 2014 at 11:54 AM, Fei Long Wang <[email protected]> wrote: > Zhi Yan, > > I think you're talking about backward-compatibility, right? I would say > it's possible, just like the v2 is not compatible with v1 against this. So > that's why I would like to see a bug is opened to track this and then we > get also some comments from the end user/product manager perspective to > decide to mark it as won't fix or go ahead. > > Thanks & Best regards, > Fei Long Wang (王飞龙) > --------------------------------------------------------------------- > Tech Lead of Nitrogen (SME team) > Cloud Solutions and OpenStack Development > Tel: 8610-82450513 | T/L: 905-0513 > Email: [email protected] > China Systems & Technology Laboratory in Beijing > --------------------------------------------------------------------- > > > [image: Inactive hide details for Zhi Yan Liu ---01/27/2014 01:02:40 > AM---One quick question, do you think there is a potential backwar]Zhi > Yan Liu ---01/27/2014 01:02:40 AM---One quick question, do you think there > is a potential backward-capability breaking issue for end use > > From: Zhi Yan Liu <[email protected]> > To: "OpenStack Development Mailing List (not for usage questions)" < > [email protected]>, > Cc: "OpenStack Development Mailing List (not for usage questions)" < > [email protected]> > Date: 01/27/2014 01:02 AM > > Subject: Re: [openstack-dev] [glance]A question abount the > x-image-meta-property parameter. > ------------------------------ > > > > One quick question, do you think there is a potential backward-capability > breaking issue for end user or ISV if we remove existing > standardizing/normalizing logic? I'd like to know the gains/advantages on > this "fix". > > thanks, > zhiyan > > Sent from my iPad > > On 2014年1月26日, at 23:49, Fei Long Wang > <*[email protected]*<[email protected]>> > wrote: > > > Hey Jay, thanks for calling my name correctly :) > > Wang Hong, feel free to open a bug to track this. And we can get more > info/comments when the patch is reviewed. Thanks. > > > Thanks & Best regards, > Fei Long Wang (王飞龙) > --------------------------------------------------------------------- > Tech Lead of Nitrogen (SME team) > Cloud Solutions and OpenStack Development > Tel: 8610-82450513 | T/L: 905-0513 > Email: *[email protected]* <[email protected]> > China Systems & Technology Laboratory in Beijing > --------------------------------------------------------------------- > > > <graycol.gif>Jay Pipes ---01/26/2014 11:20:40 PM---On Sun, 2014-01-26 > at 18:48 +0800, Fei Long Wang wrote: > Hi Wang Hong, > > From: Jay Pipes <*[email protected]* <[email protected]>> > To: Fei Long Wang/China/IBM@IBMCN, > Cc: "OpenStack Development Mailing List (not for usage questions)" < > *[email protected]* <[email protected]> > > > Date: 01/26/2014 11:20 PM > Subject: Re: [openstack-dev] [glance]A question abount the > x-image-meta-property parameter. > > ------------------------------ > > > > On Sun, 2014-01-26 at 18:48 +0800, Fei Long Wang wrote: > > Hi Wang Hong, > > > > Good catch. I think the issue is caused by line 244-246, see > > > > *https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244*<https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244> > For > the case-matter issue, I think it's a bug. But as for the - to _, I would > like to listen Jay's opinion since who is the original author. And > obviously, it's intentional change. > > Hi Wang Hong adnd Fei Long, > > It's been a long time since I wrote that :) To be honest, I'm not sure > why -- other than just standardizing/normalizing the input, we did > that. > Perhaps it had something to do with vendor-specific properties that had > a prefix that used hyphens, but I'm really not sure... perhaps I am > getting too old :) > > Best, > -jay > > > Inactive hide details for 王宏 ---01/26/2014 05:14:02 PM---Hi all. If > > I use the following command to create an image:王宏 ---01/26/2014 > > 05:14:02 PM---Hi all. If I use the following command to create an > > image: > > > > From: 王宏 <*[email protected]* <[email protected]>> > > To: > *[email protected]*<[email protected]>, > > > Date: 01/26/2014 05:14 PM > > Subject: [openstack-dev] [glance]A question abount the > > x-image-meta-property parameter. > > > > > > > > > ______________________________________________________________________ > > > > > > > > Hi all. > > > > If I use the following command to create an image: > > curl -i -H "X-Auth-Token:268c536db05b435bb6e631158744e3f6" -H > > "x-image-meta-property-IMAGE-TYPE:xxx" -H "x-image-meta-name:test" -X > > POST *http://127.0.0.1:9292/v1/images*<http://127.0.0.1:9292/v1/images> > > > > I will get the following results: > > {"image": {"status": "queued", "deleted": false, "container_format": > > null, "min_ram": 0, "updated_at": "2014-01-26T08:51:54", "owner": > > "9a38c1cda5344dd288331b988739c834", "min_disk": 0, "is_public": > false, > > "deleted_at": null, "id": "696ab97d-0e6f-46f1-8570-b6db707a748b", > > "size": 0, "name": "test", "checksum": null, "created_at": > > "2014-01-26T08:51:54", "disk_format": null, "properties": > > {"image_type": "xxx"}, "protected": false}} > > > > The capital letters in the property will be converted to lowercase > > letters and "-" will be converted to "_"("IMAGE-TYPE"=>"image_type"). > > > > Is it a bug? Thanks. > > > > Best regards. > > wanghong_______________________________________________ > > OpenStack-dev mailing list > > *[email protected]*<[email protected]> > > > *http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev*<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> > > > > > > _______________________________________________ > OpenStack-dev mailing list > *[email protected]* <[email protected]> > *http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev*<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> > _______________________________________________ > OpenStack-dev mailing list > [email protected] > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > _______________________________________________ > OpenStack-dev mailing list > [email protected] > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
<<graycol.gif>>
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
