> This change was recently merged: > > https://review.openstack.org/#/c/69133/ > > Unfortunately it didn't enable lazy translations for the unit tests, so it > didn't catch the many places in Heat that won't work when lazy translations > are enabled. Notably there are a lot of cases where the code adds the result > of a call to _() with another string, and Message objects (which are > returned from _ when lazy translations are enabled) can't be added, > resulting in an exception being raised. > > I think the best course of action would be to revert this change, and then > reintroduce it along with patches to fix all the problems, while enabling it > for the unit tests so bugs won't be reintroduced in the future.
+1 for me to revert it. It broke Heat before, and it did it again because we didn't have any tests. Let's have a proper test environment for not making that mistake again and again. -- Thomas _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev