On 03/03/2014 08:20 AM, Sean Dague wrote: > I restacked the final 2 changes to just be the tox fixes to actually run > this code - https://review.openstack.org/#/c/66156/ > > It looks like there are still 2 unit test failures in there even after > the 4 changes above. > > Did you see those in your local environment? > > -Sean
I haven't seen any problem either in Sid or in Wheezy. However, I was only running the SQLite and MySQL unit tests because I (wrongly) didn't care enough about the others. So maybe the issue is with other back-ends. I've added yet another patch for the "SADeprecationWarning: Use ``<obj>.name.quote``" in the file migrate/changeset/ansisql.py, line 234, and 257: https://review.openstack.org/#/c/77480/ It looks like my patch fixes the first unit test failure. Though we still need a fix for the 2nd problem: AttributeError: 'module' object has no attribute 'AbstractType' Any idea how to (cleanly) fix that one? It looks like that'd be the last thing we need to fix to have full SQLA 0.9 support! :) Also, maybe that last patch should be *before* the tox changes. Can a simple "git rebase -i" and a "git review" change the order of the paches? I don't dare trying, fearing to break something. Thomas Goirand (zigo) _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
