On 11/03/14 10:20, Xurong Yang wrote: > It's allowed to create duplicate sg with the same name. > so exception happens when creating instance with the duplicate sg name.
Hi Xurong - fyi there is a review open which raises this particular point at https://review.openstack.org/#/c/79270/2 (together with associated bug). imo we shouldn't be using 'name' to distinguish security groups - that's what the UUID is for, thanks, marios > code following: > .... > security_groups = kwargs.get('security_groups', []) > security_group_ids = [] > > # TODO(arosen) Should optimize more to do direct query for security > # group if len(security_groups) == 1 > if len(security_groups): > search_opts = {'tenant_id': instance['project_id']} > user_security_groups = neutron.list_security_groups( > **search_opts).get('security_groups') > > for security_group in security_groups: > name_match = None > uuid_match = None > for user_security_group in user_security_groups: > if user_security_group['name'] == security_group: > if name_match:---------------exception happened here > raise exception.NoUniqueMatch( > _("Multiple security groups found matching" > " '%s'. Use an ID to be more specific.") % > security_group) > > name_match = user_security_group['id'] > .... > > so it's maybe improper to create instance with the sg name parameter. > appreciation if any response. > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev