On 11/03/14 16:25 -0700, Clint Byrum wrote:
Hi. I asked in #openstack-glance a few times today but got no response, so sorry for the list spam.https://review.openstack.org/#/c/79710/ This change introduces a backward incompatible change to defaults with Havana. If a user has chosen to configure swift, but did not add swift to the known_stores, then when that user upgrades Glance, Glance will fail to start because their swift configuration will be invalid. This broke TripleO btw, which tries hard to use default configurations.
I don't think this change has to be reverted. We could add an upgrade path for this. We could enable a driver if its config options were set and warn the user about this change. Also, we could make sure we import all drivers and the config options are registered but that we don't try to enable them. Also, I don't expect (yeah, I know this is not always the case) users to blindly upgrade if they really care about their cloud deployment. Since this change will be part of the change log and the release notes, I expect the user to be aware of it.
Also I am not really sure why this approach was taken. If a user has explicitly put swift configuration options in their config file, why not just load swift store? Oslo.config will help here in that you can just add all of the config options but not actually expect them to be set. It seems entirely backwards to just fail in this case.
This is exactly the problem. With the current approach, the user has not explicitly enabled the swift store. The user just put swift configs. With the current 'enable all and let it fail' approach, it is really confusing for users to see all the failures and it's not nice to enable things by default for the user. Thanks for raising this issue, I didn't think about this corner case. Flavio -- @flaper87 Flavio Percoco
pgpmk_F9F9rJP.pgp
Description: PGP signature
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
