Hi Dharmit, You can't remove those from Nova. If you remove them, attach volume won't work anymore. Attach volume still goes through Nova.
Thanks, Xing -----Original Message----- From: Dharmit Shah [mailto:[email protected]] Sent: Wednesday, March 19, 2014 8:03 AM To: [email protected] Subject: [openstack-dev] [Nova] First time contributing to some project Hello Stackers, This is the first time I am mailing some dev mailing list and first time I am trying to contribute on some open source project. I am working on a low-hanging-fruit bug (https://bugs.launchpad.net/nova/+bug/1261909). It's about removing hba specific code from nova as cinder manages the volume part. The function in question is get_fc_hbas() in the nova/virt/libvirt/utils.py file. This function is being referred by get_fc_hbas_info() function in the same file and connect_volume() function in nova/virt/libvirt/volume.py file. Issue is that the latter is being used in a lot of other files across nova code. I think the same connect_volume() function is defined in cinder/brick/initiator/connector.py file and has similar code as that in nova/virt/libvirt/volume.py. Should I just nuke all the get_fc_hbas(), get_fc_hbas_info() and connect_volume() definitions and reference from the nova code? I am really confused about how I should proceed further on this. Can someone please help me get started with this? Thanks! -- Dharmit Shah _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
