So I have had a chance to look over the whole review history again. I agree with Sean Dague and Dean Troyer's concerns that the current patch affects code outside of lib/storage and extras.d. We should make the Devstack extension system more flexible to allow for more extensions. Although I am not sure if this responsibility falls completely in the lap of those wishing to integrate Ceph.
What is more concerning though is the argument that *even when the Ceph patch meets these standards* *it will still have to be pulled in from some external source. *Devstack is a central part of OpenStack's test and development system. Core projects depend upon it to develop and test drivers. As an operator, I use it to understand how changes might affect my production system. Documentation. Bug Triage. Outreach. Each of these tasks and efforts benefit from having a curated and maintained set extras in the mainline codebase. Particularly extras that are already represented by mainline drivers in other projects. I am hopeful that def core() will help in creating a logical framework for these considerations. ~ Scott On Fri, Apr 4, 2014 at 4:25 AM, Chmouel Boudjnah <chmo...@enovance.com>wrote: > Hello, > > We had quite a lengthy discussion on this review : > > https://review.openstack.org/#/c/65113/ > > about a patch that seb has sent to add ceph support to devstack. > > The main issues seems to resolve around the fact that in devstack we > support only packages that are in the distros and not having to add > external apt sources for that. > > In devstack we are moving as well toward a nice and solid plugin system > where people can hook externally and not needing to submit patch to add > a feature that change the 'core' of devstack. > > I think the best way to go forward with this would be to : > > * Split the patch mentioned above to get the generic things bit in > their own patch. i.e the storage file : > > https://review.openstack.org/#/c/65113/19/lib/storage > > and the create_disk (which would need to be used by lib/swift as well) : > > https://review.openstack.org/#/c/65113/19/functions > > * Get the existing drivers converted to that new storage format. > > * Adding new hooks to the plugin system to be able to do what we want > for this: > > https://review.openstack.org/#/c/65113/19/lib/cinder > > and for injecting things in libvirt : > > https://review.openstack.org/#/c/65113/19/lib/nova > > Hopefully to have folks using devstack and ceph would just need to be : > > $ git clone devstack > $ curl -O lib/storages/ceph http://..../ceph_devstack > (and maybe an another file for extras.d) > > am I missing a step ? > > Cheers, > Chmouel. > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev