Hi Doug, Thanks for the response! I agree with you in the cases where we are extending things like panels; if you're extending those, you're extending the dashboard itself. However, things such as workflows feel like they could reasonably live independently of the dashboard for re-use elsewhere.
Incidentally, I know that within openstack_dashboard there are cases where, say, the admin dashboard extends instances tables from the project dashboard. That feels a bit odd to me; wouldn't it be cleaner to have both dashboards extend some common instances table that lives independently of either dashboard? Thanks, Tzu-Mainn Chen ----- Original Message ----- > Hey Tzu-Mainn, > > I've actually discouraged people from doing this sort of thing when > customizing Horizon. IMO it's risky to extend those panels because they > really aren't intended as extension points. We intend Horizon to be > extensible by adding additional panels or dashboards. I know you are > closely involved in Horizon development, so you are better able to manage > that better than most customizers. > > Still, I wonder if we can better address this for Tuskar-UI as well as > other situations by defining extensibility points in the dashboard panels > and workflows themselves. Like well defined ways to add/show a column of > data, add/hide row actions, add/skip a workflow step, override text > elements, etc. Is it viable to create a few well defined extension points > and meet your need to modify existing dashboard panels? > > In any case, it seems to me that if you are overriding the dashboard > panels, it's reasonable that tuskar-ui should be dependent on the > dashboard. > > Doug Fish > > > > > > From: Tzu-Mainn Chen <tzuma...@redhat.com> > To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org>, > Date: 05/28/2014 11:40 AM > Subject: [openstack-dev] [Horizon][Tuskar-UI] Location for common > dashboard code? > > > > Heya, > > Tuskar-UI is currently extending classes directly from openstack-dashboard. > For example, right now > our UI for Flavors extends classes in both > openstack_dashboard.dashboards.admin.flavors.tables and > openstack_dashboard.dashboards.admin.flavors.workflows. In the future, > this sort of pattern will > increase; we anticipate doing similar things with Heat code in > openstack-dashboard. > > However, since tuskar-ui is intended to be a separate dashboard that has > the potential to live > away from openstack-dashboard, it does feel odd to directly extend > openstack-dashboard dashboard > components. Is there a separate place where such code might live? > Something similar in concept > to > https://github.com/openstack/horizon/tree/master/openstack_dashboard/usage > ? > > > Thanks, > Tzu-Mainn Chen > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev