Our phase 1 of spawn refactor merged a week or 2 ago and we are hard at work on phase 2 and 3. The patch set has been posted. Here is the list in order to review for your convenience
not a refactor by a trivial fix to clean up some code before the refactor https://review.openstack.org/#/c/99238 Phase 2 - these are ready for review https://review.openstack.org/#/c/98285 (DatastorePath class) https://review.openstack.org/#/c/99427 (Datatore classs) https://review.openstack.org/#/c/87002 (get_image_properties) Phase 3 - This set is still undergoing some further decomposition. But early (even just high level) comments on the approach, the extent/granularity of the unit testing will be most welcome. Also, trying to break the big patch into smaller self-contained ones is turning out to be quite a challenge. Recommendations on how we can do this sanely most appreciated as well. https://review.openstack.org/#/c/98322 (image fetching/processing/use) Related review - https://review.openstack.org/#/c/98529/ (somewhat orthogonal, more like a bit of new feature, but came out of the get_image_properties work is the descriptor-based validation of fields in the VMwareImage object)
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
