Excerpts from Duncan Thomas's message of 2014-06-17 03:56:10 -0700:
> A far more effective way to reduce the load of trivial review issues
> on core reviewers is for none-core reviewers to get in there first,
> spot the problems and add a -1 - the trivial issues are then hopefully
> fixed up before a core reviewer even looks at the patch.
> 
> The fundamental problem with review is that there are more people
> submitting than doing regular reviews. If you want the review queue to
> shrink, do five reviews for every one you submit. A -1 from a
> none-core (followed by a +1 when all the issues are fixed) is far,
> far, far more useful in general than a +1 on a new patch.
> 

Perhaps we should incentivize having a good "reviews to patches" ratio
somehow. There are probably quite a few people who are not ever going to
be core reviewers, but who don't mind doing a few reviews per day.

I can think of a few ways, but one way is to make that a real statistic
(brace yourselves for the warnings of "gaming the system") and then give
the top 10 non-core reviews to patches ratios a shout out each release.

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to