Just a quick comment from looking over oslo.utils; Does it need to bring in oslo.config? Is that needed?
The only place I am seeing it being sucked in is (correct me if I am wrong): https://github.com/dims/oslo.utils/blob/master/oslo/utils/network_utils.py# L25 (the logging module then brings in oslo.config, maybe this can just be logging not via oslo logging?) -----Original Message----- From: Doug Hellmann <[email protected]> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <[email protected]> Date: Monday, June 23, 2014 at 2:22 PM To: "OpenStack Development Mailing List (not for usage questions)" <[email protected]> Subject: Re: [openstack-dev] [oslo] oslo.utils and oslo.local >I left a few notes on one of the cleanup commits: >https://github.com/dims/oslo.utils/commit/01bca57862633ca43c8f1c05cef761ac >d85a7011 > >On Thu, Jun 19, 2014 at 7:53 AM, Davanum Srinivas <[email protected]> >wrote: >> Hi, >> >> Please review the following git repo(s): >> https://github.com/dims/oslo.local >> https://github.com/dims/oslo.utils >> >> the corresponding specs are here: >> https://review.openstack.org/#/c/98431/ >> https://review.openstack.org/#/c/99028/ >> >> Thanks, >> dims >> >> -- >> Davanum Srinivas :: http://davanum.wordpress.com >> >> _______________________________________________ >> OpenStack-dev mailing list >> [email protected] >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >_______________________________________________ >OpenStack-dev mailing list >[email protected] >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
