Alright I broke it up into smaller chunks. One problem I ran into was that the tests basically require the extension, plugin, db, and noop driver to exist so that is why the tests are dependents of those reviews.
Even though you can navigate in order through gerrit using the depdencies section, here is a list of links in order: https://review.openstack.org/#/c/105331/<https://review.openstack.org/#/c/105331> https://review.openstack.org/#/c/105609/ https://review.openstack.org/#/c/105610/ https://review.openstack.org/#/c/105617/ Another note: That third one is still pretty big, around 2k lines. This is because one of the new test files is around 1500 lines. Pulling down the code from the very last review should give you all the code needed to get this running (assuming the neutron config's values are pointing to the correct values). Thanks, Brandon ________________________________ From: Brandon Logan [[email protected]] Sent: Tuesday, July 08, 2014 1:53 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [Neutron][LBaaS] LBaaS API Version 2 WIP in gerrit Avishay, You're probably right about breaking it up but I wanted to get this up in gerrit ASAP. Also, I'd like to get Kyle and Mark's ideas on breaking it up. Thanks, Brandon ________________________________ From: Susanne Balle [[email protected]] Sent: Tuesday, July 08, 2014 9:24 AM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [Neutron][LBaaS] LBaaS API Version 2 WIP in gerrit Will take a look :-) Thanks for the huge amount of work put into this. On Tue, Jul 8, 2014 at 8:48 AM, Avishay Balderman <[email protected]<mailto:[email protected]>> wrote: Hi Brandon I think the patch should be broken into few standalone sub patches. As for now it is huge and review is a challenge :) Thanks Avishay -----Original Message----- From: Brandon Logan [mailto:[email protected]<mailto:[email protected]>] Sent: Tuesday, July 08, 2014 5:26 AM To: OpenStack Development Mailing List (not for usage questions) Subject: [openstack-dev] [Neutron][LBaaS] LBaaS API Version 2 WIP in gerrit https://review.openstack.org/#/c/105331 It's a WIP and the shim layer still needs to be completed. Its a lot of code, I know. Please review it thoroughly and point out what needs to change. Thanks, Brandon _______________________________________________ OpenStack-dev mailing list [email protected]<mailto:[email protected]> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected]<mailto:[email protected]> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
