> I left a comment on one of the commits, but in general here are my thoughts: > 1) I would prefer not to do things like switch to oslo.i18n outside of > Gerrit. I realize we don't have a specific existing policy for this, but > doing that significant > work outside of Gerrit is not desirable IMHO. It needs to happen either > before graduation or after import into Gerrit. > 2) I definitely don't want to be accepting "enable [hacking check]" changes > outside Gerrit. The github graduation step is _just_ to get the code in > shape so it > can be imported with the tests passing. It's perfectly acceptable to me to > just ignore any hacking checks during this step and fix them in Gerrit where, > again, > the changes can be reviewed. > At a glance I don't see any problems with the changes that have been made, > but I haven't looked that closely and I think it brings up some topics for > clarification in the graduation process.
i'm ok to revert if there are concerns. i just vaguely remember a reference in another oslo lib about waiting for i18n graduation but tbh i didn't actually check back to see what conclusion was. cheers, gord
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
