On 08/14/2014 11:37 AM, Ihar Hrachyshka wrote: > On 14/08/14 02:43, Angus Lees wrote: >> On Wed, 13 Aug 2014 11:11:51 AM Kevin Benton wrote: >>> Is the pylint static analysis that caught that error prone to >>> false positives? If not, I agree that it would be really nice if >>> that were made part of the tox check so these don't have to be >>> fixed after the fact. > >> At the moment pylint on neutron is *very* noisy, and I've been >> looking through the reported issues by hand to get a feel for >> what's involved. Enabling pylint is a separate discussion that I'd >> like to have - in some other thread. > > > Just start with non-voting check. Once all the issues are fixed, we > can enable it as voting.
Or blacklist all failures, make it voting - and then fix one issue after the other - and with each patch, remove the blacklisted number. That way no regressions come in... Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev