On 8/11/2014 4:42 AM, Daniel P. Berrange wrote:
On Mon, Aug 04, 2014 at 06:46:13PM -0400, Solly Ross wrote:
I was wondering if there was a way to get a non-readonly connection
to libvirt when running the unit tests
on the CI.  If I call `LibvirtDriver._connect(LibvirtDriver.uri())`,
it works fine locally, but the upstream
CI barfs with "libvirtError: internal error Unable to locate libvirtd
daemon in /usr/sbin (to override, set $LIBVIRTD_PATH to the name of the
libvirtd binary)".
If I try to connect by calling libvirt.open(None), it also barfs, saying
I don't have permission to connect.  I could just set it to always use
but it would be nice to be able to run some of the tests against a real
target.  The tests in question are part of 
and involve manipulating directory-based libvirt storage pools.

Nothing in the unit tests should rely on being able to connect to the
libvirt daemon, as the unit tests should still be able to pass when the
daemon is not running at all. We should be either using fakelibvirt or
mocking any libvirt APIs that need to be tested


Also, doesn't this kind of break with the test requirement on libvirt-python now? Before I was on trusty and trying to install that it was failing because I didn't have a new enough version of libvirt-bin installed. So if we require libvirt-python for tests and that requires libvirt-bin, what's stopping us from just removing fakelibvirt since it's kind of useless now anyway, right?



Matt Riedemann

OpenStack-dev mailing list

Reply via email to