At least for glance, the tox fix and the double setup problem are both
blocking the gate, so it isn't possible to fix cleanly, since both
issues need to be fixed in one commit - I think the correct thing is
to merge https://review.openstack.org/#/c/116267/ and give projects
time to fix up their issues cleanly.

On 22 August 2014 13:55, Ihar Hrachyshka <ihrac...@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi all,
>
> this week is quite bumpy for unit testing in gate. First, it was
> upgrade to new 'tox' version that broke quite some branches.
>
> And today new testtools 0.9.36 were released and were caught by gate,
> which resulted in the following unit test failures in multiple projects:
>
> TestCase.setUp was already called. Do not explicitly call setUp from
> your tests. In your own setUp, use super to call the base setUp.
>
> All branches are affected: havana, icehouse, and master.
>
> This is because the following check was released with the new version
> of the library:
> https://github.com/testing-cabal/testtools/commit/5c3b92d90a64efaecdc4010a98002bfe8b888517
>
> And the temporary fix is to merge the version pin patch in global
> requirements, backport it to stable branches, and merge the updates
> from Openstack Proposal Bot to all affected projects. The patch for
> master requirements is: https://review.openstack.org/#/c/116267/
>
> In the meantime, projects will need to fix their tests not to call
> setUp() and tearDown() twice. This will be the requirement to unpin
> the version of the library.
>
> So, please review, backport, and make sure it lands in project
> requirements files.
>
> /Ihar
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
>
> iQEcBAEBCgAGBQJT9z3cAAoJEC5aWaUY1u57DtsIAOFtK2i4zkMcC79nOrc5w9DW
> oO2b064eyLwwbQEaWeeIL2JBSLBxqNV5zeN0eZB3Sq7LQLv0oPaUNTMFG2+gvask
> JHCTAGKz776Rt7ptcfmpHURwcT9L//+1HXvd+ADtO0sYKwgmvaBF7aA4WFa4TseG
> JCnAsi5OiOZZgTo/6U1B55srHkZr0DWxqTkKKysZJbR2Pr/ZT9io8yu9uucaz9VH
> uNLfggtCcjGgccl7IqSUtVRf3lsSGuvBAxVqMszSFJQmFCjy2E26GfsTApp9KXtQ
> gbCpEns8QCnt6KF9rygjHLMbYikjbITuUfSL2okZelX9VpKNx0CS29K/tRg5/BA=
> =YavB
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Duncan Thomas

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to