On Mon, Aug 25, 2014 at 8:47 PM, Clark Boylan <cboy...@sapwetik.org> wrote:

> On Mon, Aug 25, 2014, at 06:45 PM, Murali Balcha wrote:
> > Pylint on my patch is failing with the following error:
> >
> > Module 'hashlib' has no 'sha256'
> >
> > Cinder pylint already has following exceptions,
> >
> >
> > pylint_exceptions:["Instance of 'sha1' has no 'update' member", ""]
> >
> > pylint_exceptions:["Module 'hashlib' has no 'sha224' member", ""]
> >
> >
> > So I think "hashlib has no 'sha256'" should be added to the exception
> > list as well. How can I update the exception list?
> >
> >
> > Thanks,
> >
> > Murali Balcha
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev@lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> I think this may be related to your install of python. Mine does not
> have this problem.
>
> $ python
> Python 2.7.6 (default, Mar 22 2014, 22:59:56)
> [GCC 4.8.2] on linux2
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import hashlib
> >>> hashlib.sha256
> <built-in function openssl_sha256>
> >>> hashlib.sha224
> <built-in function openssl_sha224>
> >>> s = hashlib.sha1()
> >>> s.update('somestring')
> >>>
>
> You should not need to treat these as acceptable failures.
>
> Clark
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
​
The error pointed out by Murali is actually showing up in the gate [1].  I
think adding the pylint exception is fine in this case.

[1]:
http://logs.openstack.org/68/110068/8/check/gate-cinder-pylint/8c6813d/console.html
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to