These look good to me, I will be your third core. The middle one has
some comments from Jay, but it didn't look like a big deal

Approved.

@John: can you please remove your -2's on 104048, 74537, and 99974?

Michael

On Thu, Sep 4, 2014 at 12:14 PM, Jay Pipes <jaypi...@gmail.com> wrote:
>
>
> On 09/04/2014 09:25 AM, Daniel P. Berrange wrote:
>>
>> On Thu, Sep 04, 2014 at 03:22:14PM +0200, Vladik Romanovsky wrote:
>>>
>>> Hello,
>>>
>>> I would like to ask for an extension for
>>> libvirt-start-lxc-from-block-devices feature. It has been previously pushed
>>> from Ice house to Juno.
>>> The spec [1] has been approved. One of the patches is a bug fix. Another
>>> patch has been already approved and failed in the gate.
>>> All patches has a +2 from Daniel Berrange.
>>>
>>> The list of the remaining patches are in [2].
>>>
>>>
>>> [1] https://review.openstack.org/#/c/88062
>>> [2]
>>> https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/libvirt-start-lxc-from-block-devices,n,z
>>
>>
>> The first two patches there are really both just bug fixes, so should
>> not be -2'd at all right now.
>>
>> The last patch is sufficiently trivial that I'm happy to sponsor FFE.
>
>
> Me too. It's a nice, small feature and I've previously reviewed the patches.
> Happy to second the sponsorship.
>
> -jay
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Rackspace Australia

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to