In that precise case, given how early it is in the freeze, I think
giving a quick heads-up to the -i18n team/list should be enough :) Also
/adding/ a string is not as disruptive to their work as modifying a
potentially-already-translated one.

Joe Cropper wrote:
> +1 to what Jay said.
> 
> I’m not sure whether the string freeze applies to bugs, but the defect
> that Matt mentioned (for which I authored the fix) adds a string, albeit
> to fix a bug.  Hoping it’s more desirable to have an untranslated
> correct message than a translated incorrect message.  :-)
> 
> - Joe
> On Sep 5, 2014, at 3:41 PM, Jay Bryant <jsbry...@electronicjungle.net
> <mailto:jsbry...@electronicjungle.net>> wrote:
> 
>> Matt,
>>
>> I don't think that is the right solution.
>>
>> If the string changes I think the only problem is it won't be
>> translated if it is thrown.   That is better than breaking the coding
>> standard imho.
>>
>> Jay
>>
>> On Sep 5, 2014 3:30 PM, "Matt Riedemann" <mrie...@linux.vnet.ibm.com
>> <mailto:mrie...@linux.vnet.ibm.com>> wrote:
>>
>>
>>
>>     On 9/5/2014 5:10 AM, Thierry Carrez wrote:
>>
>>         Hi everyone,
>>
>>         We just hit feature freeze[1], so please do not approve
>>         changes that add
>>         features or new configuration options unless those have been
>>         granted a
>>         feature freeze exception.
>>
>>         This is also string freeze[2], so you should avoid changing
>>         translatable
>>         strings. If you have to modify a translatable string, you
>>         should give a
>>         heads-up to the I18N team.
>>
>>         Finally, this is also DepFreeze[3], so you should avoid adding new
>>         dependencies (bumping oslo or openstack client libraries is OK
>>         until
>>         RC1). If you have a new dependency to add, raise a thread on
>>         openstack-dev about it.
>>
>>         The juno-3 development milestone was tagged, it contains more
>>         than 135
>>         features and 760 bugfixes added since the juno-2 milestone 6
>>         weeks ago
>>         (not even counting the Oslo libraries in the mix). You can
>>         find the full
>>         list of new features and fixed bugs, as well as tarball
>>         downloads, at:
>>
>>         https://launchpad.net/__keystone/juno/juno-3
>>         <https://launchpad.net/keystone/juno/juno-3>
>>         https://launchpad.net/glance/__juno/juno-3
>>         <https://launchpad.net/glance/juno/juno-3>
>>         https://launchpad.net/nova/__juno/juno-3
>>         <https://launchpad.net/nova/juno/juno-3>
>>         https://launchpad.net/horizon/__juno/juno-3
>>         <https://launchpad.net/horizon/juno/juno-3>
>>         https://launchpad.net/neutron/__juno/juno-3
>>         <https://launchpad.net/neutron/juno/juno-3>
>>         https://launchpad.net/cinder/__juno/juno-3
>>         <https://launchpad.net/cinder/juno/juno-3>
>>         https://launchpad.net/__ceilometer/juno/juno-3
>>         <https://launchpad.net/ceilometer/juno/juno-3>
>>         https://launchpad.net/heat/__juno/juno-3
>>         <https://launchpad.net/heat/juno/juno-3>
>>         https://launchpad.net/trove/__juno/juno-3
>>         <https://launchpad.net/trove/juno/juno-3>
>>         https://launchpad.net/sahara/__juno/juno-3
>>         <https://launchpad.net/sahara/juno/juno-3>
>>
>>         Many thanks to all the PTLs and release management liaisons
>>         who made us
>>         reach this important milestone in the Juno development cycle.
>>         Thanks in
>>         particular to John Garbutt, who keeps on doing an amazing job
>>         at the
>>         impossible task of keeping the Nova ship straight in troubled
>>         waters
>>         while we head toward the Juno release port.
>>
>>         Regards,
>>
>>         [1] https://wiki.openstack.org/__wiki/FeatureFreeze
>>         <https://wiki.openstack.org/wiki/FeatureFreeze>
>>         [2] https://wiki.openstack.org/__wiki/StringFreeze
>>         <https://wiki.openstack.org/wiki/StringFreeze>
>>         [3] https://wiki.openstack.org/__wiki/DepFreeze
>>         <https://wiki.openstack.org/wiki/DepFreeze>
>>
>>
>>     I should probably know this, but at least I'm asking first. :)
>>
>>     Here is an example of a new translatable user-facing error message
>>     [1].
>>
>>     From the StringFreeze wiki, I'm not sure if this is small or large.
>>
>>     Would a compromise to get this in be to drop the _() so it's just
>>     a string and not a message?
>>
>>     Maybe I should just shut-up and email the openstack-i18n mailing
>>     list [2].
>>
>>     [1] https://review.openstack.org/#__/c/118535/
>>     <https://review.openstack.org/#/c/118535/>
>>     [2]
>>     http://lists.openstack.org/__cgi-bin/mailman/listinfo/__openstack-i18n
>>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n>
>>
>>     -- 
>>
>>     Thanks,
>>
>>     Matt Riedemann
>>
>>
>>     _________________________________________________
>>     OpenStack-dev mailing list
>>     OpenStack-dev@lists.openstack.__org
>>     <mailto:OpenStack-dev@lists.openstack.org>
>>     http://lists.openstack.org/__cgi-bin/mailman/listinfo/__openstack-dev
>>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> <mailto:OpenStack-dev@lists.openstack.org>
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
Thierry Carrez (ttx)

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to