James Polley <j...@jamezpolley.com> writes:

> On Thu, Sep 11, 2014 at 6:52 AM, James E. Blair <cor...@inaugust.com> wrote:
>
>> Steven Hardy <sha...@redhat.com> writes:
>>
>> > Yeah, I don't know what the optimal solution is - my attention has
>> recently
>> > been drawn to queries generated via gerrit-dash-creator, which I'm
>> finding
>> > help a lot.
>>
>> This is one of several great solutions to the problem.  Any query in
>> Gerrit can include an age specifier.  To get the old behavior, just add
>> "age:-2week" (that translates to "last updated less than 2 weeks ago")
>> to any query -- whether a dashboard or your own bookmarked query like
>> this one:
>>
>>
>> https://review.openstack.org/#/q/status:open+age:-2week+project:openstack/nova,n,z
>
>
> If someone uploads a patch, and 15 days later it's had no comments at all,
> would it be visible in this query? My understanding is that it wouldn't, as
> it was last updated more than two weeks ago
>
> In my mind, a patch that's had no comments in two weeks should be high on
> the list of thing that need feedback. As far as I know, Gerrit doesn't have
> any way to sort by oldest-first though, so even if a two-week-old patch was
> visible in the query, it would be at the bottom of the list.

Indeed, however, a slightly different query will get you exactly what
you're looking for.  This will show changes that are at least 2 days
old, have no code reviews, are not WIP, and have passed Jenkins:

  project:openstack/nova status:open label:Verified>=1,jenkins NOT 
label:Workflow<=-1 NOT label:Code-Review<=2 age:2d

or the direct link:

  
https://review.openstack.org/#/q/project:openstack/nova+status:open+label:Verified%253E%253D1%252Cjenkins+NOT+label:Workflow%253C%253D-1+NOT+label:Code-Review%253C%253D2+age:2d,n,z

Incidentally, that is the query in the "Wayward Changes" section of the
"Review Inbox" dashboard (thanks Sean!); for nova, you can see it here:

  
https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard

The key here is that there are a lot of changes in a lot of different
states, and one query isn't going to do everything that everyone wants
it to do.  Gerrit has a _very_ powerful query language that can actually
help us make sense of all the changes we have in our system without
externalizing the cost of that onto contributors in the form of
forced-abandoning of changes.  Dashboards can help us share the
knowledge of how to get the most out of it.

  https://review.openstack.org/Documentation/user-dashboards.html
  https://review.openstack.org/Documentation/user-search.html

-Jim

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to