On 09/16/2014 03:57 AM, Thierry Carrez wrote: > Miguel Angel Ajo Pelayo wrote: >> During the ipset implementatio, we designed a refactor  to cleanup >> the firewall driver a bit, and move all the ipset low-level knowledge >> down into the IpsetManager. >> >> I'd like to see this merged for J, and, it's a bit of an urgent matter >> to decide, because we keep adding small changes   fruit of the >> early testing which break the refactor, and will add extra work which >> needs to be refactored too. >> >> The advantage of merging now, vs in J, is having K & J share a more common >> code base, which would help us during bug backports/etc in the future. >> >> Shihanzhang and I, are happy to see this merge during K, as it doesn't >> incur in functional changes, just code blocks are moved from the iptables >> firewall driver to IpsetManager, and the corresponding tests are moved too. >> [...] > > IMHO code refactoring should be considered a superfluous change at this > point in the cycle. The risk/benefit ratio is too high, and focus should > be on bugfixing at this point.
+1. Hold the refactoring until Kilo. -Sean -- Sean Dague http://dague.net _______________________________________________ OpenStack-dev mailing list OpenStackemail@example.com http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev