Hi Thomas,

I have a few suggestions inline that I hope will be helpful!

> From: Matt Riedemann <mrie...@linux.vnet.ibm.com>
> To: Douglas Fish/Rochester/IBM@IBMUS, Justin Pomeroy/Rochester/IBM@IBMUS
> Date: 09/30/2014 10:26 PM
> Subject: Fwd: Re: [openstack-dev] django-pyscss failing with Django 1.7
>
> FYI in case one of you can provide some guidance. Thomas is a Debian
> packager.
>
>
> -------- Original Message --------
> Subject: Re: [openstack-dev] django-pyscss failing with Django 1.7
> Date: Tue, 30 Sep 2014 14:03:50 +0800
> From: Thomas Goirand <z...@debian.org>
> Reply-To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Organization: Debian
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
>
> On 09/30/2014 10:10 AM, Thomas Goirand wrote:
> > Since the latest commit before the release of version 1.0.3,
> > django-pyscss fails in Sid:
> >
> > https://github.com/fusionbox/django-pyscss/commit/
> 187a7a72bf72370c739f3675bef84532e524eaf1
> >
> > The issue is that storage.prefix doesn't seem to exist anymore in
Django
> > 1.7.

I'm not sure that's really your root cause.  It seems like it _should_
exist.
I think it comes from
https://github.com/django/django/blob/master/django/contrib/staticfiles/finders.py#L71

What error message do you see?

> >
> > Does anyone have an idea how to fix this? Would it be ok to just revert
> > that commit in my Debian package?

Have you engaged with the django_pyscss guys at
https://github.com/fusionbox/django-pyscss ?
They were helpful and responsive to me when I interacted with them.

> >
> > Cheers,
> >
> > Thomas Goirand (zigo)
>
> I produced this patch:
> http://anonscm.debian.org/cgit/openstack/python-django-pyscss.git/
> tree/debian/patches/fix-storage.prefix-not-found.patch

It looks like an accurate revert to me.  At first glance I don't see why
its functionally different.  Do you know why the revert works?

>
> Does this look correct? I really would appreciate peer review, as I'm
> really not sure of what I'm doing. The only thing I know, it that it's
> looking like it's passing all unit tests, including the prefix one.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>

Doug Fish


_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to