Hi Andrey,

Generally I'm opposed to such changes enabling random PEP8 checks, but
in this particular case I kind of like the fact you fix the mess with
indents in the code.

python-novaclient code base is fairly small, CI nodes are not
overloaded at this point of the release cycle, code looks better
now... FWIW, I'd +1 your patches :)

Thanks,
Roman

On Fri, Oct 17, 2014 at 4:40 PM, Andrey Kurilin <akuri...@mirantis.com> wrote:
> Hi everyone!
>
> I'm working on enabling E12* PEP8 rules in novaclient(status of my work
> listed below). Imo, PEP8 rules should be ignored only in extreme cases/for
> important reasons and we should decrease a number of ignored rules. This
> helps to keep code in more strict, readable form, which is very important
> when working in community.
>
> While working on rule E126, we started discussion with Joe Gordon about
> demand of these rules. I have no idea about reasons of why they should be
> ignored, so I want to know:
> - Why these rules should be ignored?
> - What do you think about enabling these rules?
>
> Please, leave your opinion about E12* rules.
>
> Already enabled rules:
>   E121,E125 - https://review.openstack.org/#/c/122888/
>   E122 - https://review.openstack.org/#/c/123830/
>   E123 - https://review.openstack.org/#/c/123831/
>
> Abandoned rule:
>   E124 - https://review.openstack.org/#/c/123832/
>
> Pending review:
>   E126 - https://review.openstack.org/#/c/123850/
>   E127 - https://review.openstack.org/#/c/123851/
>   E128 - https://review.openstack.org/#/c/127559/
>   E129 - https://review.openstack.org/#/c/123852/
>
>
> --
> Best regards,
> Andrey Kurilin.
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to