-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 14/11/14 02:36, Fei Long Wang wrote: > Greetings, > > Recently, I'm working on fixing Nova evacuate bugs for RBD. And > both the two patches have been merged in Kilo[1,2]. But during > backporting them to Juno/Icehouse, one patch got a document build > failure, see > http://logs.openstack.org/26/131626/3/check/gate-nova-docs/789d9bd/console.html > > Therefore, I have to change the docstring format a little bit. But seems > there are some reviewers have concern about this. Though personally > I think it's ok, given we even could resolve conflicts by changing > code during backporting. So may I get some suggestion/comments > about this situation? Thanks.
Personally, I don't see it as a fight worth fighting. Pinning of the version in master was controversial from the start . Ideally, you would patch master docstring, then meld the patch into yours. Though once final sphinx 1.3 is released, master will be forced to fix all those issues including the docstring you backport, so I don't see there is value in pushing back the backport for such a minor reason. Let's not allow the next Juno release (2014.2.1) scheduled the end of the month to miss the fix for procedural reasons. : https://bugs.launchpad.net/oslotest/+bug/1379998/comments/5 > >  https://review.openstack.org/131626  > https://review.openstack.org/131613 > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUZcSJAAoJEC5aWaUY1u57F8UH/jNNErCnh+0zVdQqfPLYmgSw kQO2+w2WZvjq1N931eLM3Q6mdz053JamU3pUbD2aHjJTj0Zl6InPvJBUOTYZRfY1 uF0JU5jUWmbaZFKZ6Xqxre52ZOt7scyVlCO5dT/aP9D4eHoj6ZnBqWO8fDaIHhht PX2zf+/Rkof8oDivLccED71W0KWTRA4iZCA3/C5kpe111VaPE1AxRA+sRoe4bBTz XyCSGFvXbB9SDWv9kDt2IuiW6LNUeKTsjsCJHYNnYMwwLRhn7AH5m4pqGysscOOU /JITCYZTbfFiLKdlo4QdvDJ9TrUqrC+ilydUyVFBOTGTXP57443BRZHXlW0f6eg= =xx1Z -----END PGP SIGNATURE----- _______________________________________________ OpenStack-dev mailing list OpenStackemail@example.com http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev