On 12/09/2014 11:41 AM, Johannes Erdfelt wrote:
> On Tue, Dec 09, 2014, Sean Dague <s...@dague.net> wrote:
>> I'd like to propose that for hacking 1.0 we drop 2 groups of rules entirely.
>>
>> 1 - the entire H8* group. This doesn't function on python code, it
>> functions on git commit message, which makes it tough to run locally. It
>> also would be a reason to prevent us from not rerunning tests on commit
>> message changes (something we could do after the next gerrit update).
> 
> One of the problems with the H8* tests is that it can reject a commit
> message generated by git itself.
> 
> I had a 'git revert' rejected because the first line was too long :(

+1

I've had the gerrit revert button reject me for the same reason.

        -Sean

-- 
Sean Dague
http://dague.net

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to