I am working on a bug [1] on neutron vpnaas and submitted the patch here [2].

The test code to test the fix does the following
    - creates a namespace
    - creates a veth pair and add one interface into the namespace
    - configures the interface with an ip address and
    - adds a default gateway
    - and of course tests the code.

This test code only tests a specific function (OpenSwanProcess._get_nexthop())

Reviewers of this patch are not clear if this should be part of functional tests or unit tests. Can unit tests create linux namespaces, interfaces etc or it falls under functional tests?

Please let me know your thoughts on this.

[1] - https://bugs.launchpad.net/neutron/+bug/1405413
[2] - https://review.openstack.org/#/c/145005/5


OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe

Reply via email to