On Thu, Mar 26, 2015 at 12:22 AM, Monty Taylor <mord...@inaugust.com> wrote:

> git review is used by a ton of people who write in non-python. I think
> adding openstack-specific style enforcement to it would make it way less
> generally useful.
>


I think if we wanted to do that we could just extend git-review run_scripts
thing[1] to read tox.ini or other shipped with the project file to run the
pre-review script from it.

Chmouel

PS: I haven't looked at yapf so i have not much opinion about it.

[1]
https://git.openstack.org/cgit/openstack-infra/git-review/tree/git_review/cmd.py?h=master#n229
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to