On 04/27/2015 06:38 PM, Kevin L. Mitchell wrote:
On Mon, 2015-04-27 at 21:42 +0000, Jeremy Stanley wrote:
I consider it an unfortunate oversight that those files weren't
deleted a very, very long time ago.
Unfortunately, there's one problem with that: you can't tell tox to use
a virtualenv that you've built. We need this capability at present, so
we have to run tests using run_tests.sh instead of tox :( I have an
issue open on tox to address this need, but haven't seen any movement on
that; so until then, I have to oppose the removal of run_tests.sh…
despite how much *I'd* like to see it bite the dust!
Honestly, I see no problem with some helper bash scripts that simplify
life for new contributors. The bash scripts do wonders for developers
new to OpenStack or Python coding by having a pretty easy and readable
way of determining what CLI commands are used to execute tests. Hell,
devstack [1] itself was written originally in the way it was to
well-document the deployment process for OpenStack. Many packagers and
configuration management script authors have looked at devstack's Bash
scripts for inspiration and instruction in this way.
The point Ronald was making that nobody seems to have addressed is the
very valid observation that as a new contributor, it can be very
confusing to go from one project to another and see different ways of
running tests. Some projects have run_tests.sh and still actively
promote it in the devref docs. Others don't
While Ronald seems to have been the victim of unfortunate timing (he
started toying around with python-openstackclient and within a week,
they removed the script he was using to run tests), that doesn't make
his point about our inconsistency moot.
Best,
-jay
[1] http://docs.openstack.org/developer/devstack/stack.sh.html
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
