+1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial.

Regards
Filip

On 06/09/2015 09:58 PM, Kirill Zaitsev wrote:
Folks, I’ve got another proposal, mainly to the guys, who deal with CI and test jobs daily.

What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files?

I use it, when reviewing .sh scripts (well, actually my vim does it for me =P) and although It has some excessive checks I find it quite useful.

We could also add a similar job to murano-apps, since they use shell scripts quite often.

Any objections to this idea?


--
Kirill Zaitsev
Murano team
Software Engineer
Mirantis, Inc


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to