On Thu, Jul 16, 2015 at 8:39 PM, Sean M. Collins <s...@coreitpro.com> wrote:
> Hi Cathy, > > You recently merged the following patch, by +2'ing and then > Workflow+1'ing it, without allowing reviewers the chance to look at the > changes between the patchset where there were -1's and the newer > patchsets. > > https://review.openstack.org/#/c/192933/ > > I do see that you were asking on -infra about the mechanics of how to > merge a patch > > > http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2015-07-16.log.html#t2015-07-16T23:54:03 > > Just because a core member has given it a +2 and the Neutron PTL had > +2'd a previous patch, doesn't mean that you should go ahead and > unilaterally approve your own patch. That's not a way to build a > commmunity project. > > I agree with Sean here. The patch merged with only a single +2, and if the other comments were not addressed earlier, they need to be addressed with a followup patch (and reply on this email thread with the patch), or we should revert the commit and address them there. Thanks, Kyle > -- > Sean M. Collins > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev