On 07/21/2015 03:26 PM, Lucas Alvares Gomes wrote:
Hi,

So, it looks like the only reason we check the reservation field here is
because we want to return a 409 for "node is locked" rather than a 400,
right? do_node_deploy and such will raise a NodeLocked, which should do
the same as this check. It's unclear to me why we can't just remove this
check and let the conductor deal with it.


Looking at the code this assumption seems to be correct. If the RPC
methods raise NodeLocked we will return 409 as expected.

It's a bit more tricky, please see my patch: https://review.openstack.org/#/c/204081/


Cheers,
Lucas

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to