On 08/25/2015 08:59 PM, Matt Riedemann wrote: > > > On 8/25/2015 10:04 AM, Thomas Goirand wrote: >> On 08/25/2015 03:42 PM, Thomas Goirand wrote: >>> Hi, >>> [...] >>> Anyway, the result is that mock 1.3 broke 9 packages at least in Kilo, >>> currently in Sid [1]. Maybe, as packages gets rebuilt, I'll get more bug >>> reports. This really, is a depressing situation. >>> [...] >> >> Some ppl on IRC explained to me what the situation was, which is that >> the mock API has been wrongly used, and some tests were in fact wrongly >> passing, so indeed, this is one of the rare cases where breaking the API >> probably made sense. >> >> As it doesn't bring anything to repair these tests, I'm just not running >> them in Kilo from now on, using something like this: >> >> --subunit 'tests\.unit\.(?!.*foo.*) >> >> Please comment if you think that's the wrong way to go. Also, has some >> of these been repaired in the stable/kilo branch? > > I seem to remember some projects backporting the test fixes to > stable/kilo but ultimately we just capped mock on the stable branches to > avoid this issue there.
I really wish that nothing of this kind was even possible. Adding such an upper cap is like hiding the dust under the carpet: it doesn't remove the issue, it just hides it. We really have too much of these in OpenStack. Fixing broken tests was the correct thing to do, IMO. Thomas __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
