> -----Original Message----- > From: Eric Harney [mailto:ehar...@redhat.com] > Sent: Wednesday, August 26, 2015 5:15 PM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [grenade][cinder] Updates of rootwrap filters > > On 08/26/2015 09:57 AM, Dulko, Michal wrote: > > Hi, > > > > Recently when working on a simple bug  I've run into a need to change > rootwrap filters rules for a few commands. After sending fix to Gerrit  it > turns out that when testing the upgraded cloud grenade haven't copied my > updated volume.filters file, and therefore failed the check. I wonder how > should I approach the issue: > > 1. Make grenade script for Cinder to copy the new file to upgraded cloud. > > 2. Divide the patch into two parts - at first add new rules, leaving the old > ones there, then fix the bug and remove old rules. > > 3. ? > > > > Any opinions? > > > >  https://bugs.launchpad.net/cinder/+bug/1488433 > >  https://review.openstack.org/#/c/216675/ > > > I believe you have to go with option 1 and add code to grenade to handle > installing the new rootwrap filters. > > grenade is detecting an upgrade incompatibility that requires a config > change, which is a good thing. Splitting it into two patches will still > result in > grenade failing, because it will test upgrading kilo to master, not patch A to > patch B. > > Example for neutron: > https://review.openstack.org/#/c/143299/ > > A different example for nova (abandoned for unrelated reasons): > https://review.openstack.org/#/c/151408/ > > > > /me goes to investigate whether he can set the system locale to something > strange in the full-lio job, because he really thought we had fixed all of the > locale-related LVM parsing bugs by now.
Thanks, I've addressed that in following patch: https://review.openstack.org/#/c/217625/ __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev