While we're waiting for openstack-infra team to finish the stackforge
migration and review our ACL changes, I implemented the rest of the
changes agreed in this thread:
- Fuel-core group removed everywhere.
- Per-project core groups populated with individual reviewers as quoted
below. Exceptions:
- Dennis Dmitriev was approved as core in fuel-qa, fuel-devops, and
fuel-ostf after this thread was started;
- fuel-upgrades already excludes fuel-core so I couldn't modify it,
and the current list doesn't match Mike's email. It is up to current
cores [0] to bring it up to date.
[0] https://review.openstack.org/#/admin/groups/1004,members
fuel-specs and fuel-*-release groups will have to wait until ACL update
is merged (i.e. after October 17).
--
Dmitry Borodaenko
On Thu, Oct 01, 2015 at 03:59:47PM -0700, Dmitry Borodaenko wrote:
> This commit brings Fuel ACLs in sync with each other and in line with
> the agreement on this thread:
> https://review.openstack.org/230195
>
> Please review carefully. Note that I intentionally didn't touch any of
> the plugins ACLs, primarily to save time for us and the
> openstack-infra team until after the stackforge->openstack namespace
> migration.
>
> On Mon, Sep 21, 2015 at 4:17 PM, Mike Scherbakov
> <mscherba...@mirantis.com> wrote:
> > Thanks guys.
> > So for fuel-octane then there are no actions needed.
> >
> > For fuel-agent-core group [1], looks like we are already good (it doesn't
> > have fuel-core group nested). But it would need to include fuel-infra group
> > and remove Aleksandra Fedorova (she will be a part of fuel-infra group).
> >
> > python-fuel-client-core [2] is good as well (no nested fuel-core). However,
> > there is another group python-fuelclient-release [3], which has to be
> > eliminated, and main python-fuelclient-core would just have fuel-infra group
> > included for maintenance purposes.
> >
> > [1] https://review.openstack.org/#/admin/groups/995,members
> > [2] https://review.openstack.org/#/admin/groups/551,members
> > [3] https://review.openstack.org/#/admin/groups/552,members
> >
> >
> > On Mon, Sep 21, 2015 at 11:06 AM Oleg Gelbukh <ogelb...@mirantis.com> wrote:
> >>
> >> FYI, we have a separate core group for stackforge/fuel-octane repository
> >> [1].
> >>
> >> I'm supporting the move to modularization of Fuel with cleaner separation
> >> of authority and better defined interfaces. Thus, I'm +1 to such a change
> >> as
> >> a part of that move.
> >>
> >> [1] https://review.openstack.org/#/admin/groups/1020,members
> >>
> >> --
> >> Best regards,
> >> Oleg Gelbukh
> >>
> >> On Sun, Sep 20, 2015 at 11:56 PM, Mike Scherbakov
> >> <mscherba...@mirantis.com> wrote:
> >>>
> >>> Hi all,
> >>> as of my larger proposal on improvements to code review workflow [1], we
> >>> need to have cores for repositories, not for the whole Fuel. It is the
> >>> path
> >>> we are taking for a while, and new core reviewers added to specific repos
> >>> only. Now we need to complete this work.
> >>>
> >>> My proposal is:
> >>>
> >>> Get rid of one common fuel-core [2] group, members of which can merge
> >>> code anywhere in Fuel. Some members of this group may cover a couple of
> >>> repositories, but can't really be cores in all repos.
> >>> Extend existing groups, such as fuel-library [3], with members from
> >>> fuel-core who are keeping up with large number of reviews / merges. This
> >>> data can be queried at Stackalytics.
> >>> Establish a new group "fuel-infra", and ensure that it's included into
> >>> any other core group. This is for maintenance purposes, it is expected to
> >>> be
> >>> used only in exceptional cases. Fuel Infra team will have to decide whom
> >>> to
> >>> include into this group.
> >>> Ensure that fuel-plugin-* repos will not be affected by removal of
> >>> fuel-core group.
> >>>
> >>> #2 needs specific details. Stackalytics can show active cores easily, we
> >>> can look at people with *:
> >>> http://stackalytics.com/report/contribution/fuel-web/180. This is for
> >>> fuel-web, change the link for other repos accordingly. If people are added
> >>> specifically to the particular group, leaving as is (some of them are no
> >>> longer active. But let's clean them up separately from this group
> >>> restructure process).
> >>>
> >>> fuel-library-core [3] group will have following members: Bogdan D.,
> >>> Sergii G., Alex Schultz, Vladimir Kuklin, Alex Didenko.
> >>> fuel-web-core [4]: Sebastian K., Igor Kalnitsky, Alexey Kasatkin, Vitaly
> >>> Kramskikh, Julia Aranovich, Evgeny Li, Dima Shulyak
> >>> fuel-astute-core [5]: Vladimir Sharshov, Evgeny Li
> >>> fuel-dev-tools-core [6]: Przemek Kaminski, Sebastian K.
> >>> fuel-devops-core [7]: Tatyana Leontovich, Andrey Sledzinsky, Nastya
> >>> Urlapova
> >>> fuel-docs-core [8]: Irina Povolotskaya, Denis Klepikov, Evgeny
> >>> Konstantinov, Olga Gusarenko
> >>> fuel-main-core [9]: Vladimir Kozhukalov, Roman Vyalov, Dmitry Pyzhov,
> >>> Sergii Golovatyuk, Vladimir Kuklin, Igor Kalnitsky
> >>> fuel-nailgun-agent-core [10]: Vladimir Sharshov, V.Kozhukalov
> >>> fuel-ostf-core [11]: Tatyana Leontovich, Nastya Urlapova, Andrey
> >>> Sledzinsky, Dmitry Shulyak
> >>> fuel-plugins-core [12]: Igor Kalnitsky, Evgeny Li, Alexey Kasatkin
> >>> fuel-qa-core [13]: Andrey Sledzinsky, Tatyana Leontovich, Nastya Urlapova
> >>> fuel-stats-core [14]: Alex Kislitsky, Alexey Kasatkin, Vitaly Kramskikh
> >>> fuel-tasklib-core [15]: Igor Kalnitsky, Dima Shulyak, Alexey Kasatkin
> >>> (this project seems to be dead, let's consider to rip it off)
> >>> fuel-specs-core: there is no such a group at the moment. I propose to
> >>> create one with following members, based on stackalytics data [16]: Vitaly
> >>> Kramskikh, Bogdan Dobrelia, Evgeny Li, Sergii Golovatyuk, Vladimir Kuklin,
> >>> Igor Kalnitsky, Alexey Kasatkin, Roman Vyalov, Dmitry Borodaenko, Mike
> >>> Scherbakov, Dmitry Pyzhov. We would need to reconsider who can merge after
> >>> Fuel PTL/Component Leads elections
> >>> fuel-octane-core: needs to be created. Members: Yury Taraday, Oleg
> >>> Gelbukh, Ilya Kharin
> >>> fuel-mirror-core: needs to be created. Sergey Kulanov, Vitaly Parakhin
> >>> fuel-upgrade-core: needs to be created. Sebastian Kalinowski, Alex
> >>> Schultz, Evgeny Li, Igor Kalnitsky
> >>> fuel-provision: repo seems to be outdated, needs to be removed.
> >>>
> >>> I suggest to make changes in groups first, and then separately address
> >>> specific issues like removing someone from cores (not doing enough reviews
> >>> anymore or too many positive reviews, let's say > 95%).
> >>>
> >>> I hope I don't miss anyone / anything. Please check carefully.
> >>> Comments / objections?
> >>>
> >>> [1]
> >>> http://lists.openstack.org/pipermail/openstack-dev/2015-August/072406.html
> >>> [2] https://review.openstack.org/#/admin/groups/209,members
> >>> [3] https://review.openstack.org/#/admin/groups/658,members
> >>> [4] https://review.openstack.org/#/admin/groups/664,members
> >>> [5] https://review.openstack.org/#/admin/groups/655,members
> >>> [6] https://review.openstack.org/#/admin/groups/646,members
> >>> [7] https://review.openstack.org/#/admin/groups/656,members
> >>> [8] https://review.openstack.org/#/admin/groups/657,members
> >>> [9] https://review.openstack.org/#/admin/groups/659,members
> >>> [10] https://review.openstack.org/#/admin/groups/1000,members
> >>> [11] https://review.openstack.org/#/admin/groups/660,members
> >>> [12] https://review.openstack.org/#/admin/groups/661,members
> >>> [13] https://review.openstack.org/#/admin/groups/662,members
> >>> [14] https://review.openstack.org/#/admin/groups/663,members
> >>> [15] https://review.openstack.org/#/admin/groups/624,members
> >>> [16] http://stackalytics.com/report/contribution/fuel-specs/180
> >>>
> >>>
> >>> --
> >>> Mike Scherbakov
> >>> #mihgen
> >>>
> >>>
> >>> __________________________________________________________________________
> >>> OpenStack Development Mailing List (not for usage questions)
> >>> Unsubscribe:
> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>>
> >> __________________________________________________________________________
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> > --
> > Mike Scherbakov
> > #mihgen
> >
> > __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
>
> --
> Dmitry Borodaenko
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
