On 11/17/2015 10:37 PM, Nikhil Manchanda wrote:
Thanks for putting up that fix Matt. The dependency on trunk python-troveclient (for stable/kilo) definitely seems screwy-- but I'm wondering if this was done for backwards compatibility reasons? (i.e. to ensure the latest version of python-troveclient should be able to work correctly against all previous releases of trove.)
If that was the plan, https://review.openstack.org/#/c/210004/ totally blows that up since it's a backward incompatible change and was released in a minor version rather than a major version. That change is really what's breaking stable/kilo trove unit tests.
Either way, I think we should be honoring the requirements specified for the respective releases in g-r, so I think that this is the right fix. Cheers, Nikhil On Tue, Nov 17, 2015 at 7:42 PM, Matt Riedemann <mrie...@linux.vnet.ibm.com <mailto:mrie...@linux.vnet.ibm.com>> wrote: On 11/17/2015 9:27 PM, Matt Riedemann wrote: On 11/17/2015 9:22 PM, Matt Riedemann wrote: I noticed this failing today: http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_061 Looks like https://review.openstack.org/#/c/218701/ and maybe the dependent python-troveclient change would need to be backported to stable/kilo (neither are clean backports), or we can just skip the test on stable/kilo if there is a good reason why it won't work. I also see that the unit test job on stable/kilo is pulling in trunk python-troveclient: http://logs.openstack.org/81/206681/3/check/gate-trove-python27/45d645d/console.html#_2015-11-17_17_07_28_393 Even though we have troveclient capped at 1.1.0 in kilo g-r: https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L136 So how is that happening? Oh, because of this: https://github.com/openstack/trove/blob/stable/kilo/test-requirements.txt#L17 And that's terrible....why are we doing that? Attempting to fix here: https://review.openstack.org/#/c/246735/ -- Thanks, Matt Riedemann __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-- Thanks, Matt Riedemann __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
