On 11/23/2015 06:42 PM, Armando M. wrote:
On 23 November 2015 at 09:22, Carl Baldwin <[email protected]
<mailto:[email protected]>> wrote:
On Mon, Nov 23, 2015 at 5:02 AM, Rossella Sblendido
<[email protected] <mailto:[email protected]>> wrote:
> To cross-reference we can use the bug ID or the blueprint name.
>
> I created a script that queries launchpad to get:
> 1) Bug number of the bugs tagged with approved-rfe
> 2) Bug number of the critical/high bugs
> 3) list of blueprints targeted for the current milestone (mitaka-1)
Rossella, this is a great start! In principle, I have wanted
something like this for a long time now. The process of scraping
launchpad and gerrit manually for the most important stuff to review
is labor intensive and sometimes I just want to take a little bit of
extra time and review something. It is very tempting to go straight
to gerrit and pick something. I think it is very important for us to
finally crack this nut and have a dashboard which can help us easily
find the most important reviews. I think your time on this is very
well spent and will positively affect the whole team.
Thanks a lot Carl! I really hope it will be useful :)
> With this info the script builds a .dash file that can be used by
> gerrit-dash-creator [2] to produce a dashboard url .
>
> The script prints also the queries that can be used in gerrit UI
directly,
> e.g.:
> Critical/High Bugs
> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
> topic:bug/1513765 OR topic:bug/1514810)
>
> This is the dashboard I get right now [3]
>
> I tried in many ways to get Gerrit to filter patches if the
commit message
> contains a bug ID. Something like:
>
> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
> message:"#1513765" OR message:"#1514810")
>
> but it doesn't work well, the result of the filter contains
patches that
> have nothing to do with the bugs queried.
> That's why I had to filter using the topic.
>
> CAVEAT: To make the dashboard work, bug fixes must use the topic
"bug/ID"
> and patches implementing a blueprint the topic "bp/name". If a
patch is not
> following this convention it won't be showed in the dashboard,
since the
> topic is used as filter. Most of us use this convention already
anyway so I
> hope it's not too much of a burden.
>
> Feedback is appreciated :)
I looked for the address scopes blueprint [1] which is targeted for
Mitaka-1 [2] and there are 6 (or 5, one is in the gate) patches on the
bp/address-scopes topic [3]. It isn't obvious to me yet why it didn't
get picked up on the dashboard. I've only started to look in to this
and may not have much time right now. I wondered if you could easily
tell why it didn't get picked up.
Isn't it missing bp/ ? From the URL I can only see topic:address-scope,
which isn't the right one.
Yes Armando is right. I fixed that. Another reason is that I am
filtering out patches that are WIP or that failed Jenkins tests. This
can be changed anyway. This is what I get now (after fixing the missing
'bp/') [1]
cheers,
Rossella
[1] goo.gl/C7UjdD
Given that I only see one review in
the blueprints section, I suspect there are other blueprints which are
in the same situation.
[1] https://blueprints.launchpad.net/neutron/+spec/address-scopes
[2] https://launchpad.net/neutron/+milestone/mitaka-1
[3]
https://review.openstack.org/#/q/status:open+topic:bp/address-scopes,n,z
Thanks!
Carl
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
[email protected]?subject:unsubscribe
<http://[email protected]?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
