On 11/26/2015 02:34 PM, Steven Hardy wrote:
On Thu, Nov 26, 2015 at 01:37:16PM +0100, Lennart Regebro wrote:
We are proposing to have an "answers file" for the tripleoclient so
that you don't have to have a ling line of

    openstack overcloud deploy --templates /home/stack/mytemplates
--environment superduper.yaml --environment loadsofstuff.yaml
--envirnoment custom.yaml

But instead can just do

    opennstack overcloud deploy --answers-file answers.yaml

And in that file have:

   templates: /home/stack/mytemplates
   environments:
     - superduper.yaml
     - loadsofstuff.yaml
     - custom.yaml

I like the idea of this, provided we keep the scope limited to what is not
already possible via the heat environment files.

So, for example in the reply from Qasim Sarfraz there is mention of passing
other deployment parameters, and I would prefer we did not do that, because
it duplicates functionality that already exists in the heat environment
(I'll reply separately to explain that further).

I do have a couple of questions:

1. How will this integrate with the proposal to add an optional environment
directory? See https://review.openstack.org/#/c/245172/

2. How will this integrate with non "deploy" actions, such as image
building (e.g both the current interface and the new yaml definition
proposed in https://review.openstack.org/#/c/235569/)

It's probably fine to say it's only scoped to the deploy command initially,
but I wanted to at least consider if a broader answer-file format could be
adopted which could potentially support all overcloud * commands.

deploy and update actually, as per the change request, given you'll probably want those to remain the same on update

haven't checked the submission in the details but have a few comments:

1. what is the benefit of having the templates location specified in the answers file as well? how about keeping the templates path out of the yaml?

2. I'd also rename the answers file into something like environments-file, given it's not an answers-file but more a list of env files

3. in which order are the env files appended? it is important that order is respected and known in advance to the user

4. how does this behave if one is passing some env with -e as well? looks like we should append the -e files to the list of environments gathered from environments-file?

5. make sure not to mangle the file paths; these can be absolute or relative to the templates location
--
Giulio Fidente
GPG KEY: 08D733BA

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to