Sofer Athlan-Guyot wrote: > Hi, > > There are a few places where I would like to be able to check for IPv6 > address and add bracket to the parameters. I think that would be a nice > addition to the puppet-openstacklib/lib/puppet/parser. > > Here the interface I have in mind with the puppet-nova module: > > class nova::vncproxy::common ( > $vncproxy_host = undef, > $vncproxy_protocol = undef, > $vncproxy_port = undef, > $vncproxy_path = undef, > ) { > > include ::nova::deps > > $vncproxy_host_real = pick( > ipv6_add_bracket_maybe($vncproxy_host, > $::nova::compute::vncproxy_host, > $::nova::vncproxy::host, > false) > > > This would returns an array with the host decorated with "[]" if the > value is an IPv6 address. Ideally the function could take only one > value and return it or take an array and return an array for seamless > integration in the code. > > WDYT? >
I see this and it looks like that only only reason this is a problem is because we've broken up all the pieces of data needed to generate a URI so it becomes inappropriate to decorate the vncproxy_host variable's value with "[]" because it lacks the port appended to the end. What are the ramifications of simply switching to a "$vnc_uri" variable much the same that has happened with identity_uri and auth_uri, e.g. https://review.openstack.org/262799. If one has to simply define the entire URI, they'll be able to properly decorate the IPv6 address. -- Cody
signature.asc
Description: OpenPGP digital signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev