Sean M. Collins <[email protected]> wrote:
On Fri, Jan 08, 2016 at 07:50:47AM PST, Chris Dent wrote:
On Fri, 8 Jan 2016, Gary Kotton wrote:
The commit https://github.com/openstack/neutron/commit/5d53dfb8d64186-
b5b1d2f356fbff8f222e15d1b2 may break the decomposed plugins that make
use of the method _get_tenant_id_for_create
Just out of curiosity, is it not standard practice that a plugin
shouldn't use a private method?
+1 - hopefully decomposed plugins will audit their code and look for
other calls to private methods.
The fact that it broke *aas repos too suggests that we were not showing a
proper example to those decomposed. I think it can be reasonable to restore
the method until N, with a deprecation message, as Garry suggested in his
patch. Especially since there is no actual burden to keep the method for
another cycle.
Ihar
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
