Hi Abishek, In my understanding, hacking check is enabled for most (or all) of python-*client. For example, flake8 is run for each neutronclient review [1]. test-requirements installs hacking, so I believe hacking check is enabled. openstackclient and novaclient do the same [2] [3]. Am I missing something?
[1] http://git.openstack.org/cgit/openstack/python-neutronclient/tree/tox.ini#n26 [2] http://git.openstack.org/cgit/openstack/python-openstackclient/tree/tox.ini#n15 [3] http://git.openstack.org/cgit/openstack/python-novaclient/tree/tox.ini#n24 2016-01-19 14:18 GMT+09:00 Kekane, Abhishek <[email protected]>: > Hi Devs, > > > > As of now all OpenStack projects has hacking checks which take cares about > OpenStack guidelines issues are caught while running PEP8 checks using tox. > > There are no such checks in any of the python-*client. > > > > IMO its worth to enable hacking checks in python-*clients as well which will > caught some guidelines issues in local environment only, > > > > Please let me know your opinion on the same. > > > > Thanks & Regards, > > > > Abhishek Kekane > > > ______________________________________________________________________ > Disclaimer: This email and any attachments are sent in strictest confidence > for the sole use of the addressee and may contain legally privileged, > confidential, and proprietary data. If you are not the intended recipient, > please advise the sender by replying promptly to this email and then delete > and destroy this email and any attachments without any further use, copying > or forwarding. > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
