Ah, thanks Henry!

I went ahead and filed a bug too, marked it as duplicate of the one you
linked.

  
\--

Aditya

  

On Mar 29 2016, at 6:06 pm, Henry Gessau <[email protected]> wrote:  

> https://launchpad.net/bugs/1563028  
https://review.openstack.org/298855

>

> Aditya Vaja <[email protected]> wrote:  
> Hi,  
>  
> I'm seeing unit test failures when I test locally after a fresh git clone
of  
> neutron master.  
>  
> $ ./run_tests.sh -V -f  
>  
&gt; log excerpt: <http://paste.openstack.org/show/492384/>  
&gt;  
&gt; I update the requirements.txt to use 'Routes&lt;2.0,&gt;=1.12.3' and all
the tests  
&gt; work fine.  
&gt; I see there was a new release (v2.3 ) of Routes on 28th March 2016 [1],
which  
&gt; seems to have caused the issue, specifically:  
&gt; \- Concatenation fix when using submappers with path prefixes. Multiple  
&gt; submappers combined the path prefix inside the controller argument in  
&gt; non-obvious ways. The controller argument will now be properly carried
through  
&gt; when using submappers. PR #28[2].  
&gt;  
&gt; Is anyone else noticing the test failures?  
&gt; Should I submit this requirements.txt change as a patch or should we pass
the  
&gt; required two args as the patch? I can do the requirement.txt change. For
the  
&gt; latter, somebody who knows what goes on in the extensions.py __init__()
should  
&gt; take a look.  
&gt;  
&gt; I assume this will also affect the stable branches, since the Routes
package  
&gt; versin in requirements.txt in previous versions was same as in master.  
&gt;  
&gt; \--  
&gt; Aditya  
&gt; [1] https://routes.readthedocs.org/en/latest/changes.html#release-2-3-mar
ch-28-2016  
&gt; [2] https://github.com/bbangert/routes/pull/28/files?diff=unified#diff-
b54de741c3f86d76eb4bce4a223054aaL154

>

> __________________________________________________________________________  
OpenStack Development Mailing List (not for usage questions)  
Unsubscribe: [email protected]?subject:unsubscribe  
<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [email protected]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to