> -----Original Message----- > From: Ryan Rossiter [mailto:[email protected]] > Sent: May 03, 2016 16:10 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [nova] Austin summit versioned notification > > > > On May 3, 2016, at 8:58 AM, Matt Riedemann > <[email protected]> wrote: > > > > On 5/3/2016 3:10 AM, Balázs Gibizer wrote: > >> Hi, > >> > >> Last week Friday in Austin we discussed the way forward with the > versioned > >> notification transformation in Nova. > >> > >> We agreed that when we separate the object model use for notifications > from > >> the nova object model we still use the NovaObject as a base class to avoid > >> change in the wire format and the major version bump it would cause. > >> However we won't register the notification object into the > NovaObjectRegistry. > > > > We also said that since the objects won't be registered, we still want to > > test > their hashes in case something changes, so register the notification objects > in > the test that checks for changes (even though they aren't registered > globally), this will keep us from slipping. > > I found yesterday that we do this for the DeviceBus object here [1]. We'll be > doing something similar with all objects that inherit from the notification > base > objects in either the test_versions(), or in setUp() of TestObjectVersions, > whichever gives us the most coverage and least interference on other tests.
Thanks for the idea. I will fix up the patch [6] based on this code soon. Cheers, Gibi [6 ]https://review.openstack.org/#/c/309454/ > > [1]: > https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/t > est_objects.py#L1254-L1260 > > > > >> In general we agreed that we move forward with the transformation > according > >> to the spec [1]. > >> > >> Regarding the schema generation for the notifications we agreed to > >> propose a general JSON Schema generation implementation to > >> oslo.versionedobjects [2] that can be used in Nova later to generate > >> schemas for the notification object model. > >> > >> To have a way to synchronize our effort I'd like to restart the weekly > >> subteam meeting [5]. As the majority of the subteam is in US and EU I > propose > >> to continue the currently existing time slot UTC 17:00 every Tuesday. > >> I proposed the frequency increase from biweekly to weekly here [3]. > >> This means that we can meet today 17:00 UTC [4] on #openstack- > meeting-4. > >> > >> Cheers, > >> Gibi > >> > >> [1] https://review.openstack.org/#/c/286675/ Versioned notification > transformation > >> [2] https://review.openstack.org/#/c/311194/ versionedobjects: add json > schema generation > >> [3] https://review.openstack.org/#/c/311948/ > >> [4] > https://www.timeanddate.com/worldclock/fixedtime.html?iso=20160503T1 > 70000 > >> [5] https://wiki.openstack.org/wiki/Meetings/NovaNotification > >> > >> > >> > __________________________________________________________ > ________________ > >> OpenStack Development Mailing List (not for usage questions) > >> Unsubscribe: OpenStack-dev- > [email protected]?subject:unsubscribe > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >> > > > > > > -- > > > > Thanks, > > > > Matt Riedemann > > > > > > > __________________________________________________________ > ________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: OpenStack-dev- > [email protected]?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > ----- > Thanks, > > Ryan Rossiter (rlrossit) > > > __________________________________________________________ > ________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev- > [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
