Hello, Shinobu, We have gate test for pep8 in the CI pipeline, for import orders, if it's incorrect, pep8 gate check will give -1 in the result.
I checked the core.py in the repository, the import order is ok, first import system level, then OSLO, then projects level with blank line between different level import https://github.com/openstack/tricircle/blob/master/tricircle/db/core.py Best Regards Chaoyi Huang ( Joe Huang ) -----Original Message----- From: Shinobu Kinjo [mailto:[email protected]] Sent: Friday, May 20, 2016 11:54 AM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [tricircle] Coding style guidelines Hi Zhipeng, Please have a look at the following script. e.g., import orders. ./tricirlce/db/core.py Cheers, Shinobu On Fri, May 20, 2016 at 12:41 PM, Zhipeng Huang <[email protected]> wrote: > Hi shinobu, could you provide an example of which part of code need > modification to fit the guideline ? > > On Fri, May 20, 2016 at 11:04 AM, Shinobu Kinjo <[email protected]> > wrote: >> >> Hi Team, >> >> Please make sure that your coding style follows OpenStack style >> guidelines. [1] >> >> I understand that it's really painful but readability, and >> maintenanceability point of view, it is very important to follow >> standard. >> >> Working through code bases, some of them do not follow the guidelines. >> Please read the guide line. >> >> Thank you for your understanding. >> >> [1] http://docs.openstack.org/developer/hacking/ >> >> Cheers, >> S >> >> -- >> Email: >> [email protected] >> [email protected] >> >> _____________________________________________________________________ >> _____ OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> [email protected]?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > -- > Zhipeng (Howard) Huang > > Standard Engineer > IT Standard & Patent/IT Prooduct Line > Huawei Technologies Co,. Ltd > Email: [email protected] > Office: Huawei Industrial Base, Longgang, Shenzhen > > (Previous) > Research Assistant > Mobile Ad-Hoc Network Lab, Calit2 > University of California, Irvine > Email: [email protected] > Office: Calit2 Building Room 2402 > > OpenStack, OPNFV, OpenDaylight, OpenCompute Aficionado > > ______________________________________________________________________ > ____ OpenStack Development Mailing List (not for usage questions) > Unsubscribe: > [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Email: [email protected] [email protected] __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
